Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Shipping internal package for webcil #99380

Merged
merged 5 commits into from
Mar 11, 2024
Merged

[wasm][debugger] Shipping internal package for webcil #99380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a26793d
shipping internal package for webcil
thaystg Mar 6, 2024
32218a8
adding new pkgproj
thaystg Mar 7, 2024
c945ebf
addressing akoeplinger comments
thaystg Mar 8, 2024
0e07075
remove unrelated changes
thaystg Mar 8, 2024
b1f7c9b
Merge branch 'main' into dev/thays/shipInternalWebCilPackage
pavelsavara Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/nuget/mono-packages.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<ProjectReference Include="Microsoft.NET.Runtime.WebAssembly.Sdk\Microsoft.NET.Runtime.WebAssembly.Sdk.pkgproj" />
<ProjectReference Include="..\wasm\templates\Microsoft.NET.Runtime.WebAssembly.Templates.csproj" />
<ProjectReference Include="Microsoft.NET.Sdk.WebAssembly.Pack\Microsoft.NET.Sdk.WebAssembly.Pack.pkgproj" />

<ProjectReference Include="Microsoft.NET.WebAssembly.Webcil\Microsoft.NET.WebAssembly.Webcil.pkgproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pkgproj doesn't exist, you'd need to create it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to add the file!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaystg if all you need is a nuget package then you don't need the .pkgproj (which is kinda deprecated), you can just set <IsPackable>true</IsPackable> in the .csproj.

<ProjectReference Include="Microsoft.NET.Runtime.WorkloadTesting.Internal\Microsoft.NET.Runtime.WorkloadTesting.Internal.pkgproj" />
</ItemGroup>

Expand Down
5 changes: 2 additions & 3 deletions src/tasks/Microsoft.NET.WebAssembly.Webcil/Microsoft.NET.WebAssembly.Webcil.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<Serviceable>true</Serviceable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<IsShipping>true</IsShipping>
<!-- this assembly should not produce a public package, rather it's meant to be shipped by the
WasmAppBuilder task and the BrowserDebugProxy -->
<!-- this assembly should produce a non-shipping package, because it will be used by BrowserDebugProxy -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WasmAppBuilder still uses this though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

<IsShippingPackage>false</IsShippingPackage>
</PropertyGroup>

Expand All @@ -24,5 +23,5 @@
<Compile Include="$(CoreLibSharedDir)System\Diagnostics\CodeAnalysis\NullableAttributes.cs" Link="System\Diagnostics\CodeAnalysis\NullableAttributes.cs" />
<Compile Include="..\Common\IsExternalInit.cs" />
</ItemGroup>

<Target Name="GetFilesToPackage" />
</Project>
Loading