-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analyzer to use FeatureGuardAttribute #99340
Conversation
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsThis replaces FeatureCheckAttribute with FeatureGuardAttribute in the form that was approved in #96859 (comment). Removes FeatureDependsOnAttribute and replaces it with FeatureGuardAttribute on the property. Since it is not allowed on types, feature requirements must be "bubbled up" to the guard property, so the tests are updated to do so.
|
What's the plan for generalizing the analyzer? Presumably with these new attributes being added to the core libraries, we'll be shipping an analyzer for them that's not tied to illink? |
In the API review we decided that there aren't enough use cases for a generalized analyzer yet (that's why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This replaces FeatureCheckAttribute with FeatureGuardAttribute in the form that was approved in #96859 (comment).
Removes FeatureDependsOnAttribute and replaces it with FeatureGuardAttribute on the property. Since it is not allowed on types, feature requirements must be "bubbled up" to the guard property, so the tests are updated to do so.