Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workload-testing] Add properties for nuget.config path, and target t… #99277

Merged
merged 8 commits into from
Mar 6, 2024
Merged

[workload-testing] Add properties for nuget.config path, and target t… #99277

merged 8 commits into from
Mar 6, 2024

Conversation

radical
Copy link
Member

@radical radical commented Mar 5, 2024 •
edited
Loading

…o run the main target after

  • [workload-testing] build the dependencies before installing the sdk
  • CI: fix paths to trigger wbt

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Mar 5, 2024
@ghost
Copy link

ghost commented Mar 5, 2024

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

…o run the main target after

  • [workload-testing] build the dependencies before installing the sdk
Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@ghost ghost assigned radical Mar 5, 2024
@radical radical marked this pull request as ready for review March 5, 2024 08:05
@radical
Copy link
Member Author

radical commented Mar 5, 2024

@ilonatommy Would you please mind checking this does not break installing the sdk+workload for local runs?

@radical radical mentioned this pull request Mar 5, 2024
Merged
@radical radical requested a review from maraf March 5, 2024 09:21
maraf
maraf approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Mar 5, 2024
Closed
ilonatommy
ilonatommy approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifacts/dotnet-latest has wasm-experimental, wasm-tools, wasm-tools-net8, wasm-experimental-net8.
.dotnet has 0 workloads.
This is the expected state, wbt pass locally.

@radical
Copy link
Member Author

radical commented Mar 5, 2024

Thanks for the review! And @ilonatommy thank you for checking the local build!

@radical radical mentioned this pull request Mar 5, 2024
Closed
@radical
Copy link
Member Author

radical commented Mar 5, 2024

@jkotas thanks for the merge!

@kg
Copy link
Contributor

kg commented Mar 6, 2024

This looks like unrelated commits got pulled into it

@radical
Copy link
Member Author

radical commented Mar 6, 2024

This looks like unrelated commits got pulled into it

I had merged main which fixed the diff, but the list of commits still includes extra ones. I have rebased the changes on main now, and force-pushed. Because this has no other changes I will assume the earlier approvals are still valid, and merge once this is green.

@radical
Copy link
Member Author

radical commented Mar 6, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@radical
Copy link
Member Author

radical commented Mar 6, 2024

Failures are known issues.

@radical radical merged commit 4c39348 into dotnet:main Mar 6, 2024
20 of 22 checks passed
@radical radical deleted the workload-test-misc-fixes branch March 6, 2024 06:53
This was referenced Mar 6, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @kg @maraf @ilonatommy