SPMI: Avoid reading entire details CSV file into memory #99116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a streaming approach when processing the details CSV file to save on the peak memory usage. We still need to save the rows with diffs to be able to be able to pick examples to disassembly, but that list is expected to be way smaller than the full set of methods replayed.
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsSwitch to a streaming approach when processing the details CSV file to save on the peak memory usage. We still need to save the rows with diffs to be able to be able to pick examples to disassembly, but that list is expected to be way smaller than the full set of methods replayed. I hit a cc @dotnet/jit-contrib
|
|
ping @dotnet/jit-contrib, simple change that should fix some potential SPMI asmdiffs flakiness in CI. |
This was referenced Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a streaming approach when processing the details CSV file to save on the peak memory usage. We still need to save the rows with diffs to be able to be able to pick examples to disassemble, but that list is expected to be way smaller than the full set of methods replayed.
I hit a
MemoryErrorduring asmdiffs in #99048. Hopefully this fixes it.cc @dotnet/jit-contrib