Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][workload] Require the workload for wasm threading #98498

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[wasm][workload] Require the workload for wasm threading #98498

merged 1 commit into from
Feb 15, 2024

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 15, 2024 •
edited
Loading

fixes #98496

@lewing lewing requested review from radical and maraf February 15, 2024 15:55
@ghost ghost assigned lewing Feb 15, 2024
@lewing lewing added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #98496

Author: lewing
Assignees: lewing
Labels:

arch-wasm, area-Build-mono, os-browser
Milestone: -

@lewing lewing mentioned this pull request Feb 15, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 15, 2024
Closed
@lewing lewing merged commit 3848f56 into dotnet:main Feb 15, 2024
20 of 22 checks passed
@lewing lewing deleted the thread-workload branch February 15, 2024 18:08
maraf added a commit that referenced this pull request Mar 5, 2024
@maraf
Revert "Require the workload for wasm threading (#98498)"
cd94642 
This reverts commit 3848f56.
@maraf maraf mentioned this pull request Mar 5, 2024
Merged
maraf added a commit that referenced this pull request Mar 5, 2024
@maraf
Revert "Require the workload for wasm threading (#98498)" (#99280)
f077aa4 
This reverts commit 3848f56.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@radical radical Awaiting requested review from radical

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@lewing lewing

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[browser][MT] WasmEnableThreads=true should fail without workload installed
2 participants
@lewing @maraf