Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing BitCast test #98271

Closed
wants to merge 2 commits into from
Closed

Fix failing BitCast test #98271

wants to merge 2 commits into from

Conversation

MichalPetryka
Copy link
Contributor

Fixes the new tests from #97983 failing on ARM.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 10, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 10, 2024
@ghost
Copy link

ghost commented Feb 10, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes the new tests from #97983 failing on ARM.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@ryujit-bot
Copy link

Diff results for #98271

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Details here

This was referenced Feb 10, 2024
Closed
Closed
@EgorBo EgorBo mentioned this pull request Feb 11, 2024
Merged
@BruceForstall BruceForstall requested a review from EgorBo February 26, 2024 18:31
@BruceForstall
Copy link
Member

@EgorBo PTAL
cc @dotnet/jit-contrib

@MichalPetryka
Copy link
Contributor Author

MichalPetryka commented Feb 26, 2024 •
edited
Loading

The fix here is incomplete as gtNewLoadValueNode will transform indirect loads into variable loads which causes issues still, I've discussed it with @SingleAccretion on Discord and we weren't sure what's the best fix here (a simple fix would be to remove that optimization for unaligned loads but it could needlessly pessimize most platforms).
For context, this issue also affects stuff like ReadUnaligned and makes it do aligned loads when it gets a LCL_ADDR.

@MichalPetryka MichalPetryka marked this pull request as draft February 26, 2024 18:35
@MichalPetryka MichalPetryka mentioned this pull request Feb 26, 2024
Open
@EgorBo EgorBo mentioned this pull request Feb 26, 2024
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo Awaiting requested review from EgorBo

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalPetryka @ryujit-bot @BruceForstall