Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] install rejection handler on workers #97752

Merged
merged 6 commits into from
Feb 1, 2024
Merged

[browser][MT] install rejection handler on workers #97752

merged 6 commits into from
Feb 1, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 31, 2024 •
edited
Loading

  • installUnhandledErrorHandler on WebWorker when withExitOnUnhandledError()
  • replace worker.onerror with mono_exit on UI thread when withExitOnUnhandledError()
  • improve stringify_as_error_with_stack to contain reason.message
  • improve reason to always have at least some stack, stringified
  • don't appendElementOnExit on WebWorker
  • wrap worker init methods in try-catch-abort

Contributes to #76957

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 31, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 31, 2024
@pavelsavara pavelsavara requested a review from maraf January 31, 2024 10:12
@pavelsavara pavelsavara self-assigned this Jan 31, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #76957

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara force-pushed the browser_mt_rejections branch from a3bfda6 to caec738 Compare January 31, 2024 14:11
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review January 31, 2024 20:16
@pavelsavara pavelsavara requested a review from lewing as a code owner January 31, 2024 20:16
@build-analysis build-analysis bot mentioned this pull request Jan 31, 2024
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

maraf
maraf approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

src/mono/browser/runtime/startup.ts Show resolved Hide resolved
This was referenced Feb 1, 2024
Closed
Closed
@pavelsavara
Copy link
Member Author

There is WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation hanging Log

And memory access out of bounds Log

Both known and not caused here.

@pavelsavara pavelsavara merged commit fb675fa into dotnet:main Feb 1, 2024
47 of 53 checks passed
@pavelsavara pavelsavara deleted the browser_mt_rejections branch February 1, 2024 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf