Add clrgcexp to NetCoreApp #97401
Merged
Add clrgcexp to NetCoreApp #97401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrgcexp is standalone GC with Regions enabled and will also be used for experimental features.
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsclrgcexp is standalone GC with Regions enabled and will also be used for experimental features.
|
ghost
assigned 
markples
reviewed
Jan 23, 2024
src/coreclr/gc/CMakeLists.txt
Outdated
| @@ -135,3 +135,5 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}) | |||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/env) | |||
|
|
|||
| install_clr(TARGETS clrgc DESTINATIONS . sharedFramework COMPONENT runtime) | |||
| install_clr(TARGETS clrgcexp DESTINATIONS . sharedFramework COMPONENT runtime) | |||
There was a problem hiding this comment.
Are the two install_clr lines above (113 and 120) subsumed by these two? Regardless, should this new line be 64-bit-only?
There was a problem hiding this comment.
yeah needs to be 64-bit only. Have updated it now.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clrgcexp is standalone GC with Regions enabled and will also be used for experimental features.