Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Array.CopySlow to managed #97202

Merged
merged 25 commits into from
Jan 26, 2024
Merged

Convert Array.CopySlow to managed #97202

merged 25 commits into from
Jan 26, 2024

Conversation

huoyaoyuan
Copy link
Member

Also removes a case of HELPER_METHOD_FRAME.

The performance should not be a problem. The main concern is size.
coreclr.dll: 4864KB->4861KB, corelib R2R: 13660KB->13672KB

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 19, 2024
This was referenced Jan 19, 2024
Open
Closed
@jkotas
Copy link
Member

jkotas commented Jan 19, 2024

It would be nice to make this as similar as possible to native AOT implementation (or even shared with native AOT).

This was referenced Jan 19, 2024
Closed
Closed
This was referenced Jan 21, 2024
Closed
Closed
This was referenced Jan 22, 2024
Open
Open
This was referenced Jan 24, 2024
Closed
Open
Open
jkotas
jkotas approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jkotas
jkotas approved these changes Jan 25, 2024 •
edited
Loading
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Jan 25, 2024

@AaronRobinsonMSFT Could you please take a look as well?

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will finish later tonight.

src/coreclr/classlibnative/bcltype/arraynative.h Outdated Show resolved Hide resolved
src/coreclr/classlibnative/bcltype/arraynative.cpp Outdated Show resolved Hide resolved
src/coreclr/classlibnative/bcltype/arraynative.cpp Outdated Show resolved Hide resolved
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@huoyaoyuan @AaronRobinsonMSFT
Update src/coreclr/classlibnative/bcltype/arraynative.cpp
4f442b1 
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit ca703a1 into dotnet:main Jan 26, 2024
179 checks passed
@huoyaoyuan huoyaoyuan deleted the array-copyslow branch January 27, 2024 03:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalPetryka MichalPetryka MichalPetryka left review comments

@jkotas jkotas jkotas approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huoyaoyuan @jkotas @AaronRobinsonMSFT @MichalPetryka