Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize threshold of BigInteger.Parse #97101

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Optimize threshold of BigInteger.Parse #97101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7efa693
Update threshold of BigInteger.Parse
kzrnm Jan 17, 2024
4fa9457
Set threshold to 1233
kzrnm Jan 18, 2024
dad0ef2
Add comment
kzrnm Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libraries/System.Runtime.Numerics/src/System/Number.BigInteger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,13 +662,17 @@ internal static ParsingStatus TryParseBigIntegerBinaryNumberStyle(ReadOnlySpan<c
// algorithm with a running time of O(N^2). And if it is greater than the threshold, use
// a divide-and-conquer algorithm with a running time of O(NlogN).
//
// `1233`, which is approx the upper bound of most RSA key lengths, covers the majority
// of most common inputs and allows for the less naive algorithm to be used for
// large/uncommon inputs.
//
#if DEBUG
// Mutable for unit testing...
internal static
#else
internal const
#endif
int s_naiveThreshold = 20000;
int s_naiveThreshold = 1233;
private static ParsingStatus NumberToBigInteger(ref NumberBuffer number, out BigInteger result)
{
int currentBufferSize = 0;
Expand Down
Loading