Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Enable linux-x64 Mono fullAOT mini job on extra platforms #96332
[infra] Enable linux-x64 Mono fullAOT mini job on extra platforms #96332
Changes from 113 commits
fd56ecb
870e2d4
96c3dd5
fa12bb3
133f3a8
ba0c40e
82bfa05
8eb0cab
24628ff
93ec6c8
ade75a2
0345bff
451c85f
ec2fe19
8f41239
c188cfa
1ef87f2
b574489
06febc6
fbc914c
a62f417
0af7018
a2fe74a
fe59c5a
a7d7d2c
1d956f0
72f1414
a4bac46
e98235d
6fc3476
9913498
b61f8ef
a67303e
66f0481
bc13a90
5af9f34
7a1365d
358ba2a
da25b50
0691089
7775dd5
5bf0643
612fc81
c69b705
ed8f002
bc9c906
b43f611
936a59a
c20b843
f771c02
fd637c2
2e53492
2f46c1b
db8ca13
31e1c2a
2405b09
0c301ba
af288cb
c51cdc7
d03314f
d1be24d
abefc4b
b4fe13c
ca5ea14
3b45c90
9109cde
babcfde
2fa3366
fa052e6
a980751
b2db3eb
d382193
73b2fcf
9fbf7d3
37a6345
68449b8
8ac4b1b
b382cfa
cde358c
c5a3efe
6ac404f
11a9813
b570e07
7775a2f
282c3d8
cc036a5
45a56a0
7d10b31
66bae98
66026cf
a62be0e
a97d738
af7530b
93415e8
d083e9b
a7c4e56
22d1f24
ac3234c
be78293
bd5780c
4dd76cc
3924860
1ed23b5
4d03f40
16286b3
2cae292
9337786
f6f4d3a
7a235eb
698d5ea
a644946
04d8127
eeb36fb
8f94c62
f02bd65
62ffe69
e6dde0a
0f74711
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant since this PR is addressing mini full AOT, but I'm not sure if we shouldn't also pass
/p:MonoEnableLLVM=true
. For Perf AOT-llvm runs we use/p:MonoAOTEnableLLVM=true /p:MonoEnableLLVM=true /p:BuildMonoAOTCrossCompiler=true ...
for both x64 and arm64.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Based on the source code, the output directory should be different for the LLVM optimizer and the linker when
MonoAOTEnableLLVM
vsMonoEnableLLVM
is used. I suggest to address it in the LLVM-related PR.