Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ICU is loaded in tests before checking its version #96288

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Dec 23, 2023

Fixes #96279

@ghost ghost assigned jkotas Dec 23, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 23, 2023
@ghost
Copy link

ghost commented Dec 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: jkotas
Labels:

area-CodeGen-coreclr

Milestone: -

@jkotas jkotas added NO-REVIEW Experimental/testing PR, do NOT review it NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 23, 2023
@EgorBo
Copy link
Member

EgorBo commented Dec 23, 2023

@jkotas I did bisect locally and narrowed it down to 3 commits -

2350298
476a455
ec2bfd7

checking these 3 now

@EgorBo
Copy link
Member

EgorBo commented Dec 23, 2023

Could be #96187

Presumably, It changed behavior for "Checked" config?

@EgorBo
Copy link
Member

EgorBo commented Dec 23, 2023

Yeah, bisect for sure is pointing to 476a455, it doesn't make a lot of sense to me but it is 🙂 (or maybe it's flaky?)

@jkotas
Copy link
Member Author

jkotas commented Dec 24, 2023

Yeah, bisect for sure is pointing to 476a455, it doesn't make a lot of sense to me but it is

Thank you running the bisect locally! If 476a455 is the problem, it is likely that removing the eager initialization from the static constructor exposes a latent bug in the rest of the static constructor. I have pushed a delta to confirm or disprove this theory.

@jkotas jkotas closed this Dec 24, 2023
@jkotas jkotas reopened this Dec 24, 2023
@jkotas jkotas added area-System.Globalization and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Dec 24, 2023
@jkotas jkotas requested a review from EgorBo December 24, 2023 21:57
@ghost
Copy link

ghost commented Dec 24, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: jkotas
Labels:

area-System.Globalization

Milestone: -

@jkotas jkotas marked this pull request as ready for review December 24, 2023 21:57
@jkotas jkotas changed the title Testing #96279 Ensure that ICU is loaded in tests before checkin its version Dec 24, 2023
@jkotas
Copy link
Member Author

jkotas commented Dec 24, 2023

bisect for sure is pointing to 476a455, it doesn't make a lot of sense to me

The change removed ICU initialization as a side-effect that caused ICU version detection in other tests to fail silently.

@jkotas jkotas changed the title Ensure that ICU is loaded in tests before checkin its version Ensure that ICU is loaded in tests before checking its version Dec 24, 2023
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now it makes sense. Is try-catch necessary there?

Or if it fails you want some specific test to fail rather than internally in xunit?

@jkotas
Copy link
Member Author

jkotas commented Dec 24, 2023

Ah, now it makes sense. Is try-catch necessary there?
Or if it fails you want some specific test to fail rather than internally in xunit?

I have moved it into the existing try/catch.

@jkotas jkotas merged commit 9cc490e into dotnet:main Dec 25, 2023
103 of 111 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Tests.StringTests failing on windows Release NativeAOT_Libraries leg
2 participants