Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider atomics throwing #93610

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Consider atomics throwing #93610

merged 4 commits into from
Oct 25, 2023

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Oct 17, 2023 •
edited
Loading

Continuation of #93295.

Fixes #92784.
Fixes #44087.

A few diffs are expected due to the early propagation change.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 17, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2023
@ghost
Copy link

ghost commented Oct 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92784.

A few diffs are expected due to the early propagation change.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Oct 17, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Oct 18, 2023
Open
@SingleAccretion SingleAccretion marked this pull request as ready for review October 18, 2023 14:32
@SingleAccretion
Copy link
Contributor Author

x86 SPMI looks to have timed out; ARM64 SPMI looks to be #93527.

Diffs, @dotnet/jit-contrib.

jakobbotsch
jakobbotsch approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch jakobbotsch merged commit e0409d4 into dotnet:main Oct 25, 2023
133 of 139 checks passed
@BruceForstall BruceForstall mentioned this pull request Oct 26, 2023
Closed
@SingleAccretion SingleAccretion deleted the Atomics-Are-Indirs-Part-Two branch October 27, 2023 17:50
liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
@SingleAccretion @liveans
Consider atomics throwing (dotnet#93610)
2c41a61 
* Consider atomics throwing

* Remove the quirk

* Add a test

* Generate non-null assertions for atomics
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atomics are missing from GenTree::OperExceptions [RyuJIT] Unnecessary nullcheck in Exchange_long benchmark
2 participants
@SingleAccretion @jakobbotsch