Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] bench - separate scripts for memory snapshot #93548

Merged
merged 3 commits into from
Oct 16, 2023
Merged

[browser] bench - separate scripts for memory snapshot #93548

merged 3 commits into from
Oct 16, 2023

Conversation

pavelsavara
Copy link
Member

No description provided.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Oct 16, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 16, 2023
@pavelsavara pavelsavara self-assigned this Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

pavelsavara referenced this pull request Oct 16, 2023
@pavelsavara
[browser] benchmark for appstart with memory snapshot (#93477)
82e6c60
@build-analysis build-analysis bot mentioned this pull request Oct 16, 2023
Closed
@pavelsavara
Copy link
Member Author

[FAIL] System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek is unrelated

@pavelsavara pavelsavara marked this pull request as ready for review October 16, 2023 16:37
@pavelsavara pavelsavara merged commit a30d6c9 into dotnet:main Oct 16, 2023
94 of 96 checks passed
@pavelsavara pavelsavara deleted the browser_bench_snapshot2 branch October 16, 2023 16:38
radekdoulik added a commit to radekdoulik/runtime that referenced this pull request Oct 18, 2023
@radekdoulik
[wasm] Fix blazor startup measurements
2f97d39 
dotnet#93548 introduced a typo, which caused the blazor
startup measurements to not load the page completely.

The snapshot version is still not loading right, that's probably because we don't use
https yet.
@radekdoulik radekdoulik mentioned this pull request Oct 18, 2023
Merged
radekdoulik added a commit that referenced this pull request Oct 19, 2023
@radekdoulik
[wasm] Fix blazor startup measurements (#93696)
04ede0d 
#93548 introduced a typo, which caused the blazor
startup measurements to not load the page completely.

The snapshot version is still not loading right, that's probably because we don't use
https yet.
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radekdoulik radekdoulik radekdoulik approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @radekdoulik