[QUIC] Cleaned up TlsSecret and added test. #93119
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdded test for SSLKEYLOGFILE, fixed missing writing of the secret and removed direct reference from safe handle (now held by IDisposable).
|
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdded test for SSLKEYLOGFILE, fixed missing writing of the secret and removed direct reference from safe handle (now held by IDisposable).
|
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicTlsSecret.cs
Outdated
Show resolved
Hide resolved
| { | ||
| NativeMemory.Clear(_tlsSecrets, (nuint)sizeof(QUIC_TLS_SECRETS)); | ||
| NativeMemory.Free(_tlsSecrets); |
There was a problem hiding this comment.
I'm not sure this is safe. It feels like we can free the memory while MsQuic still may be trying to write to that. That was one reason why originally the native memory was tight to the MsQuic handle lifecycle.
There was a problem hiding this comment.
The dispose is called when the connection handle gets released, not from QuicConnection.DisposeAsync.
ManickaP
force-pushed
the
mapichov/quic-safe-handle
branch
2 times, most recently
from
c131283
to
58851d5
Compare
ManickaP
force-pushed
the
mapichov/quic-safe-handle
branch
from
58851d5
to
51a5be4
Compare
Added test for SSLKEYLOGFILE, fixed missing writing of the secret and removed direct reference from safe handle (now held by IDisposable).