-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD case to gcenv. #91524
Add FreeBSD case to gcenv. #91524
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsCloses #64935
|
Calculated based on #64935 (comment) and reworked from #64935 (comment). I used
Notes for future users:
|
src/coreclr/pal/src/misc/sysinfo.cpp
Outdated
@@ -431,7 +431,39 @@ GlobalMemoryStatusEx( | |||
// We do this only when we have the total physical memory available. | |||
if (lpBuffer->ullTotalPhys > 0) | |||
{ | |||
#ifndef __APPLE__ | |||
#if defined (__APPLE__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalMemoryStatusEx
in PAL is unused (outside of PAL tests); good candidate of deletion?
i.e. everything this query reports: git grep GlobalMemoryStatusEx ':/src/coreclr/pal'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Closes #64935