Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Make chrome version bumps for testing explicit, instead of automatic updates to latest #90772

Merged
merged 5 commits into from
Aug 18, 2023
Merged

[wasm] Make chrome version bumps for testing explicit, instead of automatic updates to latest #90772

merged 5 commits into from
Aug 18, 2023

Conversation

radical
Copy link
Member

@radical radical commented Aug 17, 2023 •
edited
Loading

  • [wasm] Remove automatic updates of chrome versions for testing
  • [wasm] Add eng/testing/bump-chrome-version.proj
  • [wasm] Add a github action to open PRs that bump chrome versions
  • GetChromeVersions: Check for 75 new branch positions to find the snapshot

@radical
[wasm] Remove automatic updates of chrome versions for testing
4bd21ee 
Instead, add a `eng/testing/ChromeVersions.props` that has to be updated
specifically to bump the chrome version used.
@radical radical added the arch-wasm WebAssembly architecture label Aug 17, 2023
@ghost ghost assigned radical Aug 17, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Remove automatic updates of chrome versions for testing
  • [wasm] Add eng/testing/bump-chrome-version.proj
  • GetChromeVersions: Check for 75 new branch positions to find the snapshot
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical changed the title gh action chrome ver [wasm] Make chrome version bumps for testing explicit, instead of automatic updates to latest Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Remove automatic updates of chrome versions for testing
  • [wasm] Add eng/testing/bump-chrome-version.proj
  • [wasm] Add a github action to open PRs that bump chrome versions
  • GetChromeVersions: Check for 75 new branch positions to find the snapshot
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono, needs-area-label
Milestone: -

@radical radical removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 17, 2023
@build-analysis build-analysis bot mentioned this pull request Aug 18, 2023
Closed
ilonatommy
ilonatommy approved these changes Aug 18, 2023
View reviewed changes
.github/workflows/bump-chrome-version.yml Outdated Show resolved Hide resolved
@radical @ilonatommy
Update .github/workflows/bump-chrome-version.yml
5237dae 
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
@radical radical merged commit e6f3f0c into dotnet:main Aug 18, 2023
182 checks passed
@radical radical deleted the gh-action-chrome-ver branch August 18, 2023 18:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @steveisok @ilonatommy