Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-rc1] Revert changes to HasNativeCodeReJitAware #90696

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[release/8.0-rc1] Revert changes to HasNativeCodeReJitAware #90696

merged 1 commit into from
Aug 17, 2023

Conversation

mikelle-rogers
Copy link
Member

@mikelle-rogers mikelle-rogers commented Aug 16, 2023 •
edited
Loading

Changes caused test failures.

This commit reverts changes to the commit eacb32e
We found that the previously mentioned commit, eacb32e, causes failures in the EnC tests. In addition, the commit eacb32e is not a high stakes commit, so it can easily be fixed and added to RC2.

Customer Impact

The commit eacb32e causes failures in the EnC tests.

Testing

The commit eacb32e causes failures in the EnC tests.

Risk

The risk of not merging the reverted commit is that EnC will not work reliably.

@mikelle-rogers
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3 
…0049)"

This reverts commit eacb32e.
Need to investigate changes because they caused a test failure.
@ghost ghost assigned mikelle-rogers Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Changes caused test failures.

This commit reverts changes to the commit eacb32e
We found that the previously mentioned commit, eacb32e, causes failures in the EnC tests. In addition, the commit eacb32e is not a high stakes commit, so it can easily be fixed and added to RC2.
This commit caused a failure.
The risk of not merging the reverted commit is that EnC will not work reliably.

Author: mikelle-rogers
Assignees: mikelle-rogers
Labels:

area-Diagnostics-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 17, 2023
Closed
@mikelle-rogers
Copy link
Member Author

I just verified that reverting this commit results in the tests passing.

@build-analysis build-analysis bot mentioned this pull request Aug 17, 2023
Closed
@mikelle-rogers mikelle-rogers added this to the 8.0.0 milestone Aug 17, 2023
@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Aug 17, 2023
jeffschwMSFT
jeffschwMSFT approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in RC1

@jeffschwMSFT jeffschwMSFT changed the title Revert changes to HasNativeCodeReJitAware [release/8.0-rc1] Revert changes to HasNativeCodeReJitAware Aug 17, 2023
@carlossanlop
Copy link
Member

CI failure is known: #90593

I'm waiting for Tactics approval to merge, I saw your email.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 17, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop merged commit 149a289 into dotnet:release/8.0-rc1 Aug 17, 2023
106 of 116 checks passed
@mikelle-rogers mikelle-rogers mentioned this pull request Aug 18, 2023
Merged
@radical radical mentioned this pull request Aug 28, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@tommcdon tommcdon tommcdon approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@mikelle-rogers mikelle-rogers

Labels
area-Diagnostics-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mikelle-rogers @carlossanlop @jeffschwMSFT @tommcdon @hoyosjs