Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNNE #90425

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Update DNNE #90425

merged 1 commit into from
Aug 12, 2023

Conversation

jtschuster
Copy link
Member

Fixes #90376

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 11, 2023
@ghost ghost assigned jtschuster Aug 11, 2023
@jtschuster jtschuster added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 11, 2023
@ghost
Copy link

ghost commented Aug 11, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90376

Author: jtschuster
Assignees: jtschuster
Labels:

area-System.Runtime.InteropServices, needs-area-label
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 11, 2023
Open
3 tasks
@BruceForstall
Copy link
Member

Ready to merge?

@jtschuster
Copy link
Member Author

Yes, thanks for the bump, I lost track of this waiting for CI.

@jtschuster jtschuster merged commit 39c0dbf into dotnet:main Aug 12, 2023
176 of 178 checks passed
@BruceForstall
Copy link
Member

@jtschuster @AaronRobinsonMSFT @jkoritzinsky It doesn't look like this fixed the problem. I kicked off a run after this merged, and it still has the failures:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=371718&view=ms.vss-test-web.build-test-results-tab&runId=7887268&resultId=200384&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

@jtschuster
Copy link
Member Author

I don't access to a computer to make the PR, but if you need it ASAP you can revert the version back to 1.0.27 and it should work again.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@jtschuster jtschuster

Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
4 participants
@jtschuster @BruceForstall @jkoritzinsky @AaronRobinsonMSFT