Disable objc_msgSend stubs in clang #89932
Conversation
|
Tagging subscribers to this area: @hoyosjs Issue DetailsApplies the same fix as xamarin/xamarin-macios#16231. We recently started seeing the same issue in our runtime builds, see #89925. This is because the AzDO build machines use Xcode 14 but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails. Fixes #89925
|
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
added
area-Infrastructure-libraries
and removed
area-Infrastructure-coreclr
labels
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsApplies the same fix as xamarin/xamarin-macios#16231. We recently started seeing the same issue in our runtime builds, see #89925. This is because the AzDO build machines use Xcode 14 but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails. Fixes #89925
|
akoeplinger
force-pushed
the
fix-objcmsgsend
branch
from
014bd27
to
bd0df3d
Compare
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
force-pushed
the
fix-objcmsgsend
branch
from
bd0df3d
to
5f0d0a4
Compare
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Applies the same fix as xamarin/xamarin-macios#16231. We recently started seeing the same issue in our runtime builds, see dotnet#89925. This is because the AzDO build machines use Xcode 14 but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails. Fixes dotnet#89925
akoeplinger
force-pushed
the
fix-objcmsgsend
branch
from
5f0d0a4
to
88d2fbd
Compare
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akoeplinger I am getting the following build error on my Mac with this PR applied: CMake Error at /Users/jakobbotsch/dev/dotnet/runtime/src/native/libs/System.Native/CMakeLists.txt:99 (set_source_files_properties):
set_source_files_properties called with incorrect number of arguments.
CMake Error at /Users/jakobbotsch/dev/dotnet/runtime/src/native/libs/System.Globalization.Native/CMakeLists.txt:97 (set_source_files_properties):
set_source_files_properties called with incorrect number of arguments.Any idea what could be the problem? Edit: After updating my Mac from Monterey to Ventura and then xcode from 14.2 to 14.3.1 things seem to build fine again, so feel free to disregard this. |
We were missing the objc_msgsend fix from dotnet#89932 in the mono build. Also fix an issue where CMake would complain about wrong number of arguments when CLR_CMAKE_COMMON_OBJC_FLAGS is empty, we need put the variable in quotes.
|
@jakobbotsch thanks for reporting, that is actually a real issue when the variable is empty. I fixed it in #90217 |
…ith Xcode 13 Backport of dotnet#89932 and dotnet#90217 to release/7.0
…ith Xcode 13 Backport of dotnet#89932 and dotnet#90217 to release/6.0
ghost
locked as resolved and limited conversation to collaborators
Applies the same fix as xamarin/xamarin-macios#16231.
We recently started seeing the same issue in our runtime builds, see #89925. This is because the AzDO build machines use Xcode 14 now but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails.
This happens in e.g. libSystem.Native.a or libSystem.Globalization.Native.a (the two libraries where we're using Objective-C).
Fixes #89925