Adjust DNS metrics #89813
Merged
Adjust DNS metrics #89813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdjust DNS metrics according to dotnet-dns-metrics.md from lmolkova/semantic-conventions#1 . This is a semantical change, since we are recording lookup duration instead of lookups requested. The total number of lookups can be derived though unfinished requests will not count. /cc @davidfowl Contributes to #89093.
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
noahfalk
approved these changes
Aug 1, 2023
src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionMetrics.cs
Show resolved
Hide resolved
src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionTelemetry.cs
Show resolved
Hide resolved
|
cc @JamesNK |
This was referenced Aug 2, 2023
MihaZupan
approved these changes
Aug 2, 2023
src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionMetrics.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionTelemetry.cs
Outdated
Show resolved
Hide resolved
…olutionMetrics.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
…v/runtime into adjust-dns-metrics-01
|
/azp run runtime |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 3, 2023
|
All CI failures are unrelated. |
This was
linked to
issues
Aug 4, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust DNS metrics according to dotnet-dns-metrics.md from lmolkova/semantic-conventions#1 .
This is a semantical change, since we are recording lookup duration instead of lookups requested. The total number of lookups can be derived though unfinished requests will not count. /cc @davidfowl
Contributes to #89093.