Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that tests are public #89554

Merged
merged 11 commits into from
Aug 29, 2023
Merged

Add check that tests are public #89554

merged 11 commits into from
Aug 29, 2023

Conversation

markples
Copy link
Member

@markples markples commented Jul 27, 2023 •
edited
Loading

Add checks that test methods are public and in public types.

The xunit analyzers only check the latter, but our implementation requires the former as well.

@ghost ghost assigned markples Jul 27, 2023
@markples markples added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Reflection.Metadata labels Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Note: contains #89521 and #89550

Add checks that test methods are public and in public types.

The xunit analyzers only check the latter, but our implementation requires the former as well.

Author: markples
Assignees: markples
Labels:

area-System.Reflection.Metadata
Milestone: -

@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Note: contains #89521 and #89550

Add checks that test methods are public and in public types.

The xunit analyzers only check the latter, but our implementation requires the former as well.

Author: markples
Assignees: markples
Labels:

area-CodeGen-coreclr
Milestone: -

@markples markples mentioned this pull request Jul 27, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 28, 2023
Closed
@markples markples assigned trylek and unassigned markples Aug 8, 2023
@trylek trylek requested a review from jkoritzinsky August 22, 2023 16:30
@trylek trylek marked this pull request as ready for review August 22, 2023 16:30
@trylek
Copy link
Member

trylek commented Aug 22, 2023

/azp run runtime-coreclr outerloop

@trylek
Copy link
Member

trylek commented Aug 22, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek
Copy link
Member

trylek commented Aug 22, 2023 •
edited
Loading

Runtime and outerloop are clean and the runtime-extra-platforms doesn't look any worse compared to recent runs, merging in once approved :-).

@build-analysis build-analysis bot mentioned this pull request Aug 22, 2023
Open
This was referenced Aug 22, 2023
Closed
Open
Closed
Closed
@trylek trylek merged commit 4187876 into dotnet:main Aug 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
@markples markples deleted the tests-public branch September 28, 2023 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@trylek trylek

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markples @trylek @jkoritzinsky