Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow binder gen diag locations correctly & pick up more bind input patterns #89537

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jul 26, 2023

Fixes #88865.
Fixes #89273.
Fixes #89732.
Closes #86653 (adds test).

@ghost
Copy link

ghost commented Jul 26, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88865.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration

Milestone: 8.0.0

@layomia layomia changed the title Flow binder gen location info to facilitate local diag suppression Flow binder gen diag locations correctly & pick up more bind input patterns Jul 27, 2023
@layomia layomia marked this pull request as draft July 27, 2023 18:35
@layomia
Copy link
Contributor Author

layomia commented Jul 27, 2023

Still iterating on the approach to take here. Per offline discussion with @ericstj we could tie each diagnostic to the binding invocation that specifies an input graph that contains types that we'd issue diagnostics for. Will push another commit.

Unsure what the issue with System.Diagnostics.Tracing is, but it could be that Roslyn is providing some phantom members in the graph of JsonWriterOptions/JsonEncoder on some platforms. The new approach should fix this issue.

@ericstj
Copy link
Member

ericstj commented Jul 27, 2023

Unsure what the issue with System.Diagnostics.Tracing is

/__w/1/s/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs(2055,13): error SYSLIB1100: Cannot create instance of type 'System.Diagnostics.TraceSwitch' because it has multiple public parameterized constructors.

Trace switch issue appears to be related to d4d0812 - pull the latest from main to your branch to see a local repro. cc @tarekgh

@layomia
Copy link
Contributor Author

layomia commented Jul 31, 2023

Still iterating on the approach to take here. Per offline discussion with @ericstj we could tie each diagnostic to the binding invocation that specifies an input graph that contains types that we'd issue diagnostics for. Will push another commit.

Refreshed the PR to take this approach, rather than tie diagnostics to the locations of unsupported type or property definitions.

@layomia
Copy link
Contributor Author

layomia commented Jul 31, 2023

cc @eduherminio I verified that this PR fixes your repro #89732 (comment).

@layomia layomia marked this pull request as ready for review July 31, 2023 22:39
@layomia
Copy link
Contributor Author

layomia commented Aug 1, 2023

Failure looks unrelated #89806, thanks @ericstj.

@layomia layomia merged commit b1f9634 into dotnet:main Aug 1, 2023
101 of 103 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.