Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-staging] [wasm][debugger] Using "RollForward": major for BrowserDebugHost #89003

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 17, 2023

Backport of #89960 to release/6.0-staging

/cc @thaystg

Customer Impact

If the customer has only .net8 installed it's possible to run a BlazorWebassembly app targeting .net6/.net7, but it's not possible to debug it.
Fixes #88391

Testing

Installed .net8 in a computer, created a BlazorWebAssembly app and debugged it.

Risk

Low risk, only allowing the same version that is used to run DevServer to run BrowserDebugProxy.

@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #88919 to release/6.0-staging

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@carlossanlop
Copy link
Member

When ready to review, please add the servicing-consider label so this PR shows up for Tactics.

Friendly reminder: if you want this servicing fix to be included in the September 2023 Release, you'll have to merge this PR before August 14th.

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Aug 2, 2023
@thaystg thaystg closed this Aug 3, 2023
@thaystg thaystg changed the title [release/6.0-staging] [wasm][debugger] Using "rollForwardOnNoCandidateFx": 2 for BrowserDebugHost [release/6.0-staging] [wasm][debugger] Using "RollForward": major for BrowserDebugHost Aug 3, 2023
@thaystg thaystg reopened this Aug 3, 2023
@thaystg thaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 14, 2023
@thaystg thaystg merged commit 822d1cd into release/6.0-staging Aug 14, 2023
134 of 139 checks passed
@jkotas jkotas deleted the backport/pr-88919-to-release/6.0-staging branch August 27, 2023 16:55
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants