Ignore suppressed diagnostics in code fix verifier #88492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
linkable-framework
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsFixes #88278. The failures started with 299a8c9, which pulled in changes to the test SDK such that suppressed warnings are now included in the set of warnings checked by the code fix verifier. The fix is based on similar changes in dotnet/roslyn-analyzers#6711 which picks up the same version of the testing SDK.
|
vitek-karas
approved these changes
Jul 7, 2023
|
This has now been hit by 4 different teams upgrading. I'm going to incorporate a fix directly into the SDK, hopefully by end of day. |
|
Merging to unblock PRs hitting this. We can revert this change when we pick up a roslyn SDK that has the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88278.
The failures started with 299a8c9, which pulled in changes to the test SDK such that suppressed warnings are now included in the set of warnings checked by the code fix verifier.
The fix is based on similar changes in dotnet/roslyn-analyzers#6711 which picks up the same version of the testing SDK.