[iOS] Add temp cindex attribute to build on xcode 15 #88261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without CursorKind 437, the cross build for iOS/tvOS and iOS/tvOSSimulator will fail. This change adds a temporary attribute to avoid that.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @directhex Issue DetailsWithout CursorKind 437, the cross build for iOS/tvOS and iOS/tvOSSimulator will fail. This change adds a temporary attribute to avoid that.
|
steveisok
removed
the
needs-area-label
This was referenced Jun 30, 2023
vargaz
reviewed
Jul 1, 2023
| @@ -223,6 +223,7 @@ public void ValidateRuntimeSelection() | |||
|
|
|||
| public override bool Execute() | |||
| { | |||
| bool shouldStaticLink = true; | |||
There was a problem hiding this comment.
Yeah, some version of xcode changed simulator behavior where if any dylib is deployed with the app it'll try to load it first. This was causing problems because we always static link the components.
vargaz
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without CursorKind 437, the cross build for iOS/tvOS and iOS/tvOSSimulator will fail. This change adds a temporary attribute to avoid that.