Disable Aot and Trim analyzers when building runtime tests #88209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When targeting native AOT, these analyzers are producing warnings that are treated as errors
ghost
assigned 
|
Tagging subscribers to this area: @hoyosjs Issue DetailsWhen targeting native AOT, these analyzers are producing warnings that are treated as errors
|
jkotas
commented
Jun 29, 2023
| @@ -129,6 +124,8 @@ | |||
| <!-- Disable some C# warnings for the tests. --> | |||
| <NoWarn>78,162,164,168,169,219,251,252,414,429,618,642,649,652,659,675,1691,1717,1718,3001,3002,3003,3005,3008,8981</NoWarn> | |||
| <RunAnalyzers>false</RunAnalyzers> | |||
| <EnableTrimAnalyzer>false</EnableTrimAnalyzer> | |||
There was a problem hiding this comment.
I have tried to disable it in more fine grained way first, but it turned out to be whack-a-mole.
This matches what we do for libraries tests.
There was a problem hiding this comment.
We could condition on EnableAggressiveTrimming. Those should be clean
There was a problem hiding this comment.
They are not clean today. I agree it would be a good path to take if we wanted to spend time on incrementally enabling analyzers for test build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting native AOT, these analyzers are producing warnings that are treated as errors