fix runtime build failures on ppc64le #88145

Sapana-Khemkar · 2023-06-28T15:05:01Z

Runtime build failing on ppc64le machine with below error

  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    Cannot find source file:
  
      /home/tester/runtime/src/native/external/libunwind/src/ppc64/setcontext.S
  
    Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .h .hh .h++
    .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc
  
  
  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    No SOURCES given to target: libunwind
  
  
  CMake Generate step failed.  Build files cannot be regenerated correctly.
  ~/runtime/src/coreclr
  ~/runtime/artifacts/obj/coreclr/linux.ppc64le.Release ~/runtime/src/coreclr
  Executing make   iltools  -j 8
  make: *** No rule to make target 'iltools'.  Stop.
  ~/runtime/src/coreclr
  Failed to build "CoreCLR component".
/home/tester/runtime/src/coreclr/runtime.proj(89,5): error MSB3073: The command ""/home/tester/runtime/src/coreclr/build-runtime.sh" -ppc64le -release -portablebuild=false -keepnativesymbols -os linux -outputrid rhel.9-ppc64le -component iltools" exited with code 2.

Build FAILED.

This issue has been observed after PR 87426 merged.

Also I am wondering why upstream CI is not failing for ppc64le. Here is link for ppc64le CI.

cc:
@am11 @tmds @janani66

…st any more

ghost · 2023-06-28T15:05:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime build failing on ppc64le machine with below error

  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    Cannot find source file:
  
      /home/tester/runtime/src/native/external/libunwind/src/ppc64/setcontext.S
  
    Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .h .hh .h++
    .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc
  
  
  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    No SOURCES given to target: libunwind
  
  
  CMake Generate step failed.  Build files cannot be regenerated correctly.
  ~/runtime/src/coreclr
  ~/runtime/artifacts/obj/coreclr/linux.ppc64le.Release ~/runtime/src/coreclr
  Executing make   iltools  -j 8
  make: *** No rule to make target 'iltools'.  Stop.
  ~/runtime/src/coreclr
  Failed to build "CoreCLR component".
/home/tester/runtime/src/coreclr/runtime.proj(89,5): error MSB3073: The command ""/home/tester/runtime/src/coreclr/build-runtime.sh" -ppc64le -release -portablebuild=false -keepnativesymbols -os linux -outputrid rhel.9-ppc64le -component iltools" exited with code 2.

Build FAILED.

This issue has been observed after PR 87426 merged.

Author:	Sapana-Khemkar
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

ghost · 2023-06-28T15:43:58Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime build failing on ppc64le machine with below error

  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    Cannot find source file:
  
      /home/tester/runtime/src/native/external/libunwind/src/ppc64/setcontext.S
  
    Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .h .hh .h++
    .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc
  
  
  CMake Error at /home/tester/runtime/src/native/external/libunwind_extras/CMakeLists.txt:169 (add_library):
    No SOURCES given to target: libunwind
  
  
  CMake Generate step failed.  Build files cannot be regenerated correctly.
  ~/runtime/src/coreclr
  ~/runtime/artifacts/obj/coreclr/linux.ppc64le.Release ~/runtime/src/coreclr
  Executing make   iltools  -j 8
  make: *** No rule to make target 'iltools'.  Stop.
  ~/runtime/src/coreclr
  Failed to build "CoreCLR component".
/home/tester/runtime/src/coreclr/runtime.proj(89,5): error MSB3073: The command ""/home/tester/runtime/src/coreclr/build-runtime.sh" -ppc64le -release -portablebuild=false -keepnativesymbols -os linux -outputrid rhel.9-ppc64le -component iltools" exited with code 2.

Build FAILED.

This issue has been observed after PR 87426 merged.

Also I am wondering why upstream CI is not failing for ppc64le. Here is link for ppc64le CI.

cc:
@am11 @tmds @janani66

Author:	Sapana-Khemkar
Assignees:	-
Labels:	`area-Infrastructure`, `community-contribution`
Milestone:	-

steveisok · 2023-06-28T15:53:41Z

/cc @directhex

am11

LGTM!

It seems like we are missing the clr.tools subset in the CI

runtime/eng/pipelines/runtime-community.yml

Line 66 in c06d77a

    
           buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true

, which is why it wasn't spotted earlier.

am11 · 2023-06-28T16:04:21Z

Upstream change in v1.7.0 was libunwind/libunwind#450.

tmds · 2023-06-28T16:12:52Z

Upstream change in v1.7.0 was libunwind/libunwind#450.

How does libunwind.cmake get updated when we sync with upstream libunwind?

am11 · 2023-06-28T16:17:56Z

We manually update {externalDepName}.cmake file when updating the dependencies under src/native/external. i.e. we don't use upstream build scripts.

tmds · 2023-06-28T16:36:29Z

We manually update {externalDepName}.cmake file when updating the dependencies under src/native/external

This PR removes ppc64/setcontext.S from

runtime/src/native/external/libunwind.cmake

Lines 373 to 382 in c06d77a

    
           set(libunwind_la_SOURCES_ppc64le 
        
               ${libunwind_la_SOURCES_ppc64le_common} 
        
               ${libunwind_la_SOURCES_local} 
        
               ppc64/setcontext.S 
        
               ppc64/Lapply_reg_state.c ppc64/Lreg_states_iterate.c 
        
               ppc64/Lcreate_addr_space.c ppc/Lget_save_loc.c ppc64/Lglobal.c 
        
               ppc64/Linit.c ppc/Linit_local.c 
        
               ppc64/Lregs.c ppc64/Lresume.c 
        
               ppc/Lis_signal_frame.c ppc64/Lstep.c 
        
           )

to match with:

runtime/src/native/external/libunwind/src/Makefile.am

Lines 483 to 490 in c06d77a

    
           # The list of files that go into libunwind: 
        
           libunwind_la_SOURCES_ppc64 = $(libunwind_la_SOURCES_ppc64_common)       \ 
        
                   $(libunwind_la_SOURCES_local)                                   \ 
        
           	$(libunwind_la_SOURCES_ppc)					\ 
        
           	ppc64/Lapply_reg_state.c ppc64/Lreg_states_iterate.c		\ 
        
           	ppc64/Lcreate_addr_space.c					\ 
        
           	ppc64/Lglobal.c ppc64/Linit.c					\ 
        
           	ppc64/Lregs.c ppc64/Lresume.c ppc64/Lstep.c

There are still other differences. Should we sync those too? (in a separate PR)

am11 · 2023-06-28T16:49:28Z

There are still other differences. Should we sync those too? (in a separate PR)

Yes, maybe with the criteria "compile what runtime needs, and not everything possible". The Makefile typically builds the general purpose lib for distros. We only compile the subset.

(Slightly off-topic) get_proc_info_in_range was upstreamed in libunwind 1.7. We can now rework the fallback logic for FEATURE_USE_SYSTEM_LIBUNWIND which source-build is setting:

runtime/src/coreclr/pal/src/exception/remote-unwind.cpp

Line 144 in c06d77a

#ifndef FEATURE_USE_SYSTEM_LIBUNWIND

(e.g. dladdr() that symbols from system libunwind if it's there use that before selecting the fallback logic, which is slightly less efficient)

jkoritzinsky · 2023-06-28T17:25:47Z

Would it help if we were able to use the libunwind build system directly instead of wrapping it in our own CMake logic? We can look at using some of the ExternalProject or FetchContent utilities (pointing to the local paths in the repo) to pull in vendored libs if that would make things easier.

am11 · 2023-06-28T17:48:34Z

IIRC, the rationale to keep build scripts outside the vendor dirs was:

we only build subset of external libs and this way, we are in control of what to compile for which target platform etc.
consistency - some dependencies do not provide cmake scripts, others do.

Also, the cmake scripts in libunwind/libunwind repo is not exercised in the CI (only Windows build uses it: https://github.com/libunwind/libunwind/blob/7d505a2b9d8b0dd21c24c01ee420c0d00dda8214/.github/workflows/CI-win.yml#L39). So it will be an additional maintenance overhead for us.

janani66 · 2023-06-28T20:27:50Z

LGTM!

It seems like we are missing the clr.tools subset in the CI

runtime/eng/pipelines/runtime-community.yml

Line 66 in c06d77a

buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true

, which is why it wasn't spotted earlier.

@am11 will you be adding the clr.tools to the buildArgs for the CI?

@am11

This will help us catch failures like #88145 CC @am11 @janani66

remove ppc64/setcontext.S from libunwind sources as file does not exi…

225ac9c

…st any more

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Jun 28, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2023

ViktorHofer added area-Infrastructure and removed area-Infrastructure-libraries labels Jun 28, 2023

am11 approved these changes Jun 28, 2023

View reviewed changes

am11 requested a review from jkotas June 28, 2023 15:54

am11 added area-PAL-coreclr and removed area-Infrastructure labels Jun 28, 2023

directhex approved these changes Jun 28, 2023

View reviewed changes

build-analysis bot mentioned this pull request Jun 28, 2023

Tracking issue for CI build timeouts #76454

Closed

jkotas merged commit 52bc96d into dotnet:main Jun 28, 2023

directhex added a commit that referenced this pull request Jun 28, 2023

Add clr.tools subset to runtime-community

13c8bb6

This will help us catch failures like #88145 CC @am11 @janani66

directhex mentioned this pull request Jun 28, 2023

Add clr.tools subset to runtime-community #88160

Merged

ghost locked as resolved and limited conversation to collaborators Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix runtime build failures on ppc64le #88145

fix runtime build failures on ppc64le #88145

Sapana-Khemkar commented Jun 28, 2023 •

edited

Loading

ghost commented Jun 28, 2023

ghost commented Jun 28, 2023

steveisok commented Jun 28, 2023

am11 left a comment

am11 commented Jun 28, 2023

tmds commented Jun 28, 2023

am11 commented Jun 28, 2023 •

edited

Loading

tmds commented Jun 28, 2023

am11 commented Jun 28, 2023

jkoritzinsky commented Jun 28, 2023

am11 commented Jun 28, 2023

janani66 commented Jun 28, 2023

fix runtime build failures on ppc64le #88145

fix runtime build failures on ppc64le #88145

Conversation

Sapana-Khemkar commented Jun 28, 2023 • edited Loading

ghost commented Jun 28, 2023

ghost commented Jun 28, 2023

steveisok commented Jun 28, 2023

am11 left a comment

Choose a reason for hiding this comment

am11 commented Jun 28, 2023

tmds commented Jun 28, 2023

am11 commented Jun 28, 2023 • edited Loading

tmds commented Jun 28, 2023

am11 commented Jun 28, 2023

jkoritzinsky commented Jun 28, 2023

am11 commented Jun 28, 2023

janani66 commented Jun 28, 2023

Sapana-Khemkar commented Jun 28, 2023 •

edited

Loading

am11 commented Jun 28, 2023 •

edited

Loading