Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing rpath on Bionic #87900

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Fix passing rpath on Bionic #87900

merged 2 commits into from
Jun 22, 2023

Conversation

MichalStrehovsky
Copy link
Member

#87669 had a bunch of trial and error to get it right. Turns out the form that we settled with doesn't please clang that ships in the Android NDK (`clang : error : no such file or directory: ''-Wl,-rpath,$ORIGIN'').

Cc @dotnet/ilc-contrib

#87669 had a bunch of trial and error to get it right. Turns out the clang that ships in the Android NDK really doesn't like this form (`clang : error : no such file or directory: ''-Wl,-rpath,$ORIGIN'').
@ghost
Copy link

ghost commented Jun 22, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

#87669 had a bunch of trial and error to get it right. Turns out the form that we settled with doesn't please clang that ships in the Android NDK (`clang : error : no such file or directory: ''-Wl,-rpath,$ORIGIN'').

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Jun 22, 2023

Turns out the form that we settled with doesn't please clang that ships in the Android NDK (`clang : error : no such file or directory: ''-Wl,-rpath,$ORIGIN'').

Is that on Windows host or Linux host?

SmokeTests are failing on Linux with the latest update. Do we need to condition this on Windows host vs. non-Windows host?

@MichalStrehovsky
Copy link
Member Author

Is that on Windows host or Linux host?

Windows host. I didn't think command line handling of clang would differ between Window and Linux, but worth a shot to condition it.

@MichalStrehovsky MichalStrehovsky merged commit d45c83a into main Jun 22, 2023
108 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch June 22, 2023 06:58
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants