Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][bench] Limit initial samples #86953

Merged
merged 2 commits into from
May 31, 2023

Conversation

radekdoulik
Copy link
Member

Try to limit initial samples measurement to 1 second.

Currently some of string measurements with hybrid globalization turned on can take hundreds of seconds. This makes the browser stop the benchmark and the measurement job times out.

This should limit the initial samples to take cca 1 second or take just one initial sample if it takes more time.

Also increase the initial samples for string comparison, where it was on the edge and the times were flipping between cca 5 and 10 seconds.

Try to limit initial samples measurement to 1 second.

Currently some of string measurements with hybrid globalization turned on
can take hundreds of seconds. This makes the browser stop the benchmark
and the measurement job times out.

This should limit the initial samples to take cca 1 second or take just
one initial sample if it takes more time.

Also increase the initial samples for string comparison, where it was on
the edge and the times were flipping between cca 5 and 10 seconds.
@ghost
Copy link

ghost commented May 31, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Try to limit initial samples measurement to 1 second.

Currently some of string measurements with hybrid globalization turned on can take hundreds of seconds. This makes the browser stop the benchmark and the measurement job times out.

This should limit the initial samples to take cca 1 second or take just one initial sample if it takes more time.

Also increase the initial samples for string comparison, where it was on the edge and the times were flipping between cca 5 and 10 seconds.

Author: radekdoulik
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@radekdoulik radekdoulik added this to the 8.0.0 milestone May 31, 2023
@ilonatommy
Copy link
Member

According to the runs I did on my machine, IndexOf it can take even 2,2 sec - see desc of #85254.

@radekdoulik radekdoulik merged commit d1bf019 into dotnet:main May 31, 2023
@radekdoulik
Copy link
Member Author

According to the runs I did on my machine, IndexOf it can take even 2,2 sec - see desc of #85254.

IIRC I saw some take about 6 seconds on our "slow" SBC nodes. Let see how it will look once the measurements succeed :-)

@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants