Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/66229 processing empty dictionary items #86394

Conversation

Maximys
Copy link
Contributor

@Maximys Maximys commented May 17, 2023

Fixes of #66229

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes of #66229

Author: Maximys
Assignees: -
Labels:

area-Extensions-Configuration

Milestone: -

@tarekgh
Copy link
Member

tarekgh commented May 17, 2023

@Maximys we try to minimize the changes that go to the binder. please revert the refactoring and keep only the changes that needed for the fix.

CC @layomia

@tarekgh tarekgh added needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels May 17, 2023
@layomia
Copy link
Contributor

layomia commented May 17, 2023

we try to minimize the changes that go to the binder.

This is due to ongoing development of the config binding generator (#44493). We need a stable baseline for feature parity (i.e this reflection implementation).

@tarekgh
Copy link
Member

tarekgh commented May 18, 2023

@Maximys thanks for your PR. I am going to temporarily close this one till you update the code and address all failures you see in the CI.

@tarekgh tarekgh closed this May 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants