Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the concept of "location" values from local morph #85604

Merged
merged 3 commits into from
May 5, 2023
Merged

Delete the concept of "location" values from local morph #85604

merged 3 commits into from
May 5, 2023

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 1, 2023 •
edited
Loading

No longer needed after ADDR's removal.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 1, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 1, 2023
@ghost
Copy link

ghost commented May 1, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

No longer necessary after ADDR's removal.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review May 1, 2023 20:55
@SingleAccretion
Copy link
Contributor Author

Diffs - none in code, 0.1%-0.15% TP wins (up to 0.25% for x86+MinOpts).

Linux x64 failure looks like #85371.

@dotnet/jit-contrib

@build-analysis build-analysis bot mentioned this pull request May 1, 2023
Closed
@SingleAccretion SingleAccretion mentioned this pull request May 2, 2023
Merged
@SingleAccretion
Delete the concept of "location" values from local morph
0f510d2 
No longer necessary after ADDR's removal.
AndyAyersMS
AndyAyersMS approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a commenting nit.

src/coreclr/jit/lclmorph.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/lclmorph.cpp Outdated Show resolved Hide resolved
SingleAccretion and others added 2 commits May 5, 2023 18:18
@SingleAccretion @AndyAyersMS
Fix spelling
dd49327 
Co-authored-by: Andy Ayers <andya@microsoft.com>
@SingleAccretion @AndyAyersMS
Fix spelling №2
2fb9baa 
Co-authored-by: Andy Ayers <andya@microsoft.com>
@AndyAyersMS AndyAyersMS merged commit b8bad7a into dotnet:main May 5, 2023
@AndyAyersMS
Copy link
Member

Thanks again for your work to make the jit better.

@SingleAccretion SingleAccretion deleted the No-Loc-LclMorph branch May 7, 2023 21:25
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SingleAccretion @AndyAyersMS