Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Rename DebuggerTests.EvaluateOnCallFrameTests2 to prevent timeouts #85169

Merged
merged 2 commits into from
Apr 21, 2023
Merged

[wasm][debugger] Rename DebuggerTests.EvaluateOnCallFrameTests2 to prevent timeouts #85169

merged 2 commits into from
Apr 21, 2023

Conversation

pavelsavara
Copy link
Member

See #85168

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Debugger-mono labels Apr 21, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 21, 2023
@pavelsavara pavelsavara self-assigned this Apr 21, 2023
@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

See #85168

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Debugger-mono
Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review April 21, 2023 15:02
@pavelsavara pavelsavara changed the title [wasm][debuuger] ActiveIssue for DebuggerTests.EvaluateOnCallFrameTests timeouts [wasm][debugger] ActiveIssue for DebuggerTests.EvaluateOnCallFrameTests timeouts Apr 21, 2023
@pavelsavara pavelsavara mentioned this pull request Apr 21, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 21, 2023
Closed
@lewing
Copy link
Member

lewing commented Apr 21, 2023

Looks like it timing out in the harness startup before the tests even begin exclude it from the list of tests?

@pavelsavara
Copy link
Member Author

Looks like it timing out in the harness startup before the tests even begin exclude it from the list of tests?

Yes. But all other classes in that project pass (on separate helix run).

@pavelsavara pavelsavara force-pushed the wasm_debugger_test_timeouts branch 2 times, most recently from 00777b0 to 1cc3a65 Compare April 21, 2023 17:29
@pavelsavara
Copy link
Member Author

Possibly this is just name conflict with EvaluateOnCallFrameTests2 on helix. They have same prefix. I renamed the offender and we will see what happens.

@lewing lewing merged commit 8744ae6 into dotnet:main Apr 21, 2023
@pavelsavara pavelsavara changed the title [wasm][debugger] ActiveIssue for DebuggerTests.EvaluateOnCallFrameTests timeouts [wasm][debugger] Rename DebuggerTests.EvaluateOnCallFrameTests2 to prevent timeouts Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
@pavelsavara pavelsavara deleted the wasm_debugger_test_timeouts branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@agocke agocke agocke approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@radical radical Awaiting requested review from radical

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @lewing @agocke