Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non core types for signature and other type references #85112

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Support non core types for signature and other type references #85112

merged 4 commits into from
Apr 23, 2023

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Apr 20, 2023

Contributes to #62956
Updates:

  1. Remove CodeDom references from the solution (not using anymore)
  2. Move MetadataBuilder instance from local to instance field
  3. Signatures now support non-core types and type definitions
  4. Parent types can be just defined types

@ghost ghost assigned buyaa-n Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #62956
Updates:

  1. Remove CodeDom references from the solution (not using anymore)
  2. Move MetadataBuilder instance from local to instance field
  3. Signatures now support non-core types and type definitions
  4. Parent types can be just defined types
Author: buyaa-n
Assignees: buyaa-n
Labels:

area-System.Reflection.Emit
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Apr 22, 2023
Closed
@buyaa-n
Copy link
Member Author

buyaa-n commented Apr 23, 2023

Test failure unrelated and reported

@buyaa-n buyaa-n merged commit a3fd93a into dotnet:main Apr 23, 2023
@buyaa-n buyaa-n deleted the type-handling branch April 23, 2023 00:49
@buyaa-n buyaa-n mentioned this pull request Apr 25, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@steveharter steveharter Awaiting requested review from steveharter

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT

Assignees

@buyaa-n buyaa-n

Labels
area-System.Reflection.Emit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buyaa-n @jkotas