Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[mono][aot] Enable deduplication of runtime invoke wrappers" #85048

Merged

Conversation

kotlarmilos
Copy link
Member

Reverts #84304. This PR produced regression reported in dotnet/perf-autofiling-issues#16477.

@lambdageek
Copy link
Member

Do we prefer this over #85044 ?

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Apr 19, 2023

As it was a code refactor, I think we could proceed with this PR (full revert) over #85044 (partial revert), and introduce the fixed version after the snap.

/cc: @vargaz

@kotlarmilos kotlarmilos merged commit 693663b into main Apr 19, 2023
@kotlarmilos kotlarmilos deleted the revert-84304-improvement/dedup-runtime-invoke-wrappers branch April 19, 2023 17:12
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants