[mono] [RISC-V] re-implement floating point arithmetic without r4fp #84470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
vargaz
approved these changes
Apr 7, 2023
|
mini-riscv.h needs to define |
am11
reviewed
Apr 25, 2023
| @@ -1703,12 +1702,14 @@ mono_arch_decompose_opts (MonoCompile *cfg, MonoInst *ins) | |||
|
|
|||
| case OP_IMUL: | |||
| case OP_LMUL: | |||
| case OP_RMUL: | |||
There was a problem hiding this comment.
@Xinlong-Wu, can we also handle long_mul_ovf_un here? In qemu, I'm getting:
# built with runtimeFlavor: mono
$ /runtime/artifacts/bin/testhost/net8.0-linux-Debug-riscv64/dotnet \
bin/Release/net8.0/helloworld.dll
Can't decompose the OP long_mul_ovf_un
* Assertion: should not be reached at /runtime/src/mono/mono/mini/mini-riscv.c:1731
=================================================================
Native Crash Reporting
=================================================================
Got a SIGABRT while executing native code. This usually indicates
...There was a problem hiding this comment.
sure，I will submit a pr of the progress so far.
I think it may fix this problem.
And I plan to use monthly and half monthly pr to synchronize changes in the future
There was a problem hiding this comment.
have submit a pr #85445
Now we are searching for when to push/pop lmf so that tey-catch can be executed correctly and mono can print the call stack correctly.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-implement floating point arithmetic for RISC-V as #84418 mentioned