Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/roslyn #84422

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 6, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
  • Build: 20230405.4
  • Date Produced: April 5, 2023 6:48:58 PM UTC
  • Commit: d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4
  • Branch: refs/heads/main

…405.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.7.0-1.23179.16 -> To Version 4.7.0-1.23205.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Apr 6, 2023
@lewing lewing closed this Apr 10, 2023
@lewing lewing reopened this Apr 10, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
  • Build: 20230405.4
  • Date Produced: April 5, 2023 6:48:58 PM UTC
  • Commit: d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4
  • Branch: refs/heads/main
Author: dotnet-maestro[bot]
Assignees: -
Labels:

area-codeflow, area-NativeAOT-coreclr

Milestone: -

@lewing
Copy link
Member

lewing commented Apr 11, 2023

looks like an analyzer failure in the nativeaot build

@lewing
Copy link
Member

lewing commented Apr 11, 2023

cc @jaredpar

@lewing lewing merged commit d44d93a into main Apr 11, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-2da1acfd-e414-46b1-ade4-f8ad37d22fca branch April 11, 2023 12:55
@MichalStrehovsky
Copy link
Member

cc @jaredpar

This showed up again so I filed #85082 (this time not in NativeAOT test build, but product build). It's not clear it was caused by this PR, but it's certainly suspicious that we would see an analyzer load failure in a Roslyn update PR for the first time. I looked at the commit range but it's 220 commits in the style of "Fix comment" and "merge remote-tracking branch" so can't tell if anything looks suspect. I'm not going to go over them one by one.

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow area-NativeAOT-coreclr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants