Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Fix failing parallel tests #83687

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Mar 20, 2023

Fix failing parallel tests in S.N.Quic with pro-longing the cut-off time for queued operations in MsQuic, only in tests.
Note that this against MsQuic recommendation, but since both client and server are on the same machine, in the same process, they are both "slow" the same way and this allows them to slowly deal with bursts of parallel requests.

Tested on arm machine where failures of Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Slow were 100% reproducible. After the change, the test runs without any issues.

Fixes #82769

@ghost
Copy link

ghost commented Mar 20, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix failing parallel tests in S.N.Quic with pro-longing the cut-off time for queued operations in MsQuic, only in tests.
Note that this against MsQuic recommendation, but since both client and server are on the same machine, in the same process, they are both "slow" the same way and this allows them to slowly deal with bursts of parallel requests.

Tested on arm machine where failures of Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Slow were 100% reproducible. After the change, the test runs without any issues.

Author: ManickaP
Assignees: ManickaP
Labels:

area-System.Net

Milestone: -

@ManickaP
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

Outerloop failures unrelated.

@ManickaP ManickaP merged commit dae6c24 into dotnet:main Mar 24, 2023
@ManickaP ManickaP deleted the mapichov/quic-fix-test branch March 24, 2023 08:31
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2023
@karelz karelz added this to the 8.0.0 milestone May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TestFailure] Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Slow fails on ARM
4 participants