Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain.cmake: properly set toolchain for crossbuilding on Alpine Linux #83464

Closed
wants to merge 2 commits into from
Closed

toolchain.cmake: properly set toolchain for crossbuilding on Alpine Linux #83464

wants to merge 2 commits into from

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Mar 15, 2023

Per @am11, sync changes from dotnet/arcade#11608 to test.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 15, 2023
@ghost
Copy link

ghost commented Mar 15, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Per @am11, sync changes from dotnet/arcade#11608 to test.

Author: ayakael
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution
Milestone: -

@ghost
Copy link

ghost commented Mar 15, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Per @am11, sync changes from dotnet/arcade#11608 to test.

Author: ayakael
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Mar 15, 2023
Closed
@am11 am11 mentioned this pull request Mar 16, 2023
Open
@ayakael ayakael force-pushed the arcade/sync-11608 branch from c53a13b to 5b756c7 Compare March 16, 2023 19:55
@build-analysis build-analysis bot mentioned this pull request Mar 16, 2023
Closed
@am11 am11 mentioned this pull request Mar 20, 2023
Merged
@am11 am11 requested review from jkotas and janvorli March 31, 2023 12:24
@am11
Copy link
Member

am11 commented Mar 31, 2023

cc @jkotas, @janvorli, this looks good and enables linux-musl cross build on other architectures.

Failures are known issue (according to Build Analysis).

@jkotas
Copy link
Member

jkotas commented Mar 31, 2023

Looks good to me. Should we close this PR and merge the one in Arcade?

@am11
Copy link
Member

am11 commented Mar 31, 2023

Sure, the bot will pick up the changes here in a week or so.

@jkoritzinsky
Copy link
Member

dotnet/runtime has picked up the changes from arcade, so closing this PR.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas Awaiting requested review from jkotas

@janvorli janvorli Awaiting requested review from janvorli

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayakael @am11 @jkotas @jkoritzinsky