Substitute out geopolitical term in TimeZoneInfo #82916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
tarekgh
reviewed
Mar 2, 2023
| @@ -134,7 +134,7 @@ private static List<string> ParseTimeZoneIds(StreamReader reader) | |||
| { | |||
| if (!string.IsNullOrEmpty(zoneTabFileLine) && zoneTabFileLine[0] != '#') | |||
| { | |||
| // the format of the line is "country-code \t coordinates \t TimeZone Id \t comments" | |||
| // the format of the line is "ISO 3166 territory code \t coordinates \t TimeZone Id \t comments" | |||
There was a problem hiding this comment.
It is interesting that the standard is using Country Code https://www.iso.org/iso-3166-country-codes.html. I don't mind using territory though.
lewing
approved these changes
Mar 2, 2023
tarekgh
approved these changes
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoliCheck classified the term as geopolitical. Replaced with term referred to in https://www.unix.com/man-page/freebsd/8/tzsetup/.