Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify an error condition in tryrun.cmake #82070

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Simplify an error condition in tryrun.cmake #82070

merged 2 commits into from
Feb 15, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 14, 2023

In this context, it is not necessary to list every supported architecture. This else() belongs to a chain of if conditions which deal with both arch and OS.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

In this context, it is not necessary to list every supported architecture.

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution

Milestone: -

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas jkotas merged commit 53bb518 into dotnet:main Feb 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2023
@am11 am11 deleted the patch-10 branch June 14, 2024 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants