Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove resource messages in Xml tests #81463

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Do not remove resource messages in Xml tests #81463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
<IlcTrimMetadata>false</IlcTrimMetadata>
</PropertyGroup>

<ItemGroup>
<RdXmlFile Include="default.rd.xml" />
</ItemGroup>

<PropertyGroup Condition="'$(TargetOS)' == 'browser'">
<!-- This doesn't run on V8 shell because https://bugs.chromium.org/p/v8/issues/detail?id=12541 -->
<Scenario>WasmTestOnBrowser</Scenario>
Expand Down
16 changes: 16 additions & 0 deletions src/libraries/System.Private.Xml/tests/default.rd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<Directives>
<Application>
<Assembly Name="System.Private.Xml">
<Type Name="System.SR">

<!--
This method is not actually reflected on by the tests, but its presence
tells the compiler not to optimize away the manifest resource that contains
resource strings. The tests do reflect on that one in the ExceptionVerifier class.
-->
<Method Name="GetResourceString" Dynamic="Required All" />

</Type>
</Assembly>
</Application>
</Directives>