Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Workaround MacCatalyst .app output path change in cmake 3.25 #79097

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 1, 2022

Backport of #79084 to release/7.0

/cc @akoeplinger

Customer Impact

This fixes a test build break when targetting MacCatalyst on macOS machines that have cmake 3.25 installed.

Testing

CI testing.

Risk

None, this is only used in the dotnet/runtime build.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Since AzDO macOS builders where updated to cmake 3.25 we're seeing failures because the .app doesn't end up in the expected output path anymore.
Apply a workaround to move it back to the old location.

Fixes #78778
@ghost
Copy link

ghost commented Dec 1, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79084 to release/7.0

/cc @akoeplinger

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@akoeplinger
Copy link
Member

/cc @carlossanlop

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and the fix would be valuable to have in the release/7.0 branch since all backports are currently tripping up on this.

(Note @carlossanlop is away from work)

@carlossanlop
Copy link
Member

carlossanlop commented Jan 4, 2023

Merging to unblock the test runs in this branch (Branding has been done).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants