-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced. #78235
Conversation
…rialization/JsonSerializerWrapper.Reflection.cs
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #78221 to release/7.0 /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Approved by Tactics over email. |
Approved by Tactics and signed off. runtime/src/libraries/System.Text.Json/src/System.Text.Json.csproj Lines 10 to 12 in 9e7c283
Ready to merge. |
Backport of #78221 to release/7.0
/cc @eiriktsarpalis
Customer Impact
Addresses an issue reported by a partner team. A change in #70430 regressed BOM handling in async deserialization, which under certain circumstances can result in a small number of bytes being skipped by the reader.
Testing
Added a regression covering the reported issues. Updates the async serialization stress testing harness so that the BOM character is injected in payloads.
Risk
Low. Makes a targeted change to production code addressing the bug in question.