-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XxHash128 #77944
Merged
Merged
Add XxHash128 #77944
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3b78dd9
Add XxHash128
xoofx c6bf653
Merge branch 'main' into add-xxhash128
xoofx 548c2e8
Optimize XxHash128
xoofx 4c449c0
Missing optimization
xoofx 5a19745
Fix warnings
xoofx 7b916f1
Optimize the 129 To 240 bytes case
xoofx 645dc0e
Fix warnings
xoofx 28cf734
Add missing namespace for tests
xoofx 76d86cc
Split strings in XxHash128 test
xoofx 08f670e
Try to fix tests on CI
xoofx 6f722a5
Add XxHash128 to ref
xoofx 5c1c2a7
Fix compilation errors on non .NET 7 platforms
xoofx ce89e5c
Fix compilation errors on net472
xoofx dc4a906
Update src/libraries/System.IO.Hashing/tests/XxHash64Tests.cs
xoofx 75fc262
Update src/libraries/System.IO.Hashing/tests/XxHash3Tests.cs
xoofx ea57cfc
Update src/libraries/System.IO.Hashing/tests/XxHash128Tests.cs
xoofx 5eb308a
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHashSh…
xoofx 6ed008f
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 6f04fb5
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 1989791
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 37b7046
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx 160b820
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx 8b4830b
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx 35feef1
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx fde336f
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx 436dd3f
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
xoofx 91ce914
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 5692d84
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 9589abd
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx f82d2d6
Fix usage of var
xoofx 18ab499
Fix comment XXH3 -> XXH128
xoofx 5e3db07
Rename WriteCanonical128 to WriteBigEndian128
xoofx b0fe876
Fix remaining issues
xoofx f4f5d08
Merge branch 'main' into add-xxhash128
xoofx b6452b0
Add tests for XxHash128.HashToUInt128 and GetCurrentHashAsUInt128
xoofx 02c8eb7
Remove spaces
xoofx dbcd877
Add new methods to ref
xoofx fe37c28
Try to fix ref file
xoofx 3513d77
Fix ref for .NET 7
xoofx 7c21a47
Split ref files
xoofx 7fb2234
Merge remote-tracking branch 'origin/main' into add-xxhash128
xoofx 5061e3c
Fix ref after merge
xoofx 6a8102f
Update src/libraries/System.IO.Hashing/ref/System.IO.Hashing.netcorea…
xoofx 63f2d9f
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash12…
xoofx 0599ba4
Remove System.Linq
xoofx 4505e57
Use PascalCast for local const
xoofx af4cb41
Remove XorShift64 from XxHash128
xoofx 620ef11
Remove duplicated Multiply32To64
xoofx 74eaced
Improve HashLength129To240
xoofx d4a9c9a
Reverting System.Linq for XxHash3 and XxHash128
xoofx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/libraries/System.IO.Hashing/ref/System.IO.Hashing.netcoreapp.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// ------------------------------------------------------------------------------ | ||
// Changes to this file must follow the https://aka.ms/api-review process. | ||
// ------------------------------------------------------------------------------ | ||
|
||
namespace System.IO.Hashing | ||
{ | ||
public sealed partial class XxHash128 : System.IO.Hashing.NonCryptographicHashAlgorithm | ||
{ | ||
[System.CLSCompliantAttribute(false)] | ||
public System.UInt128 GetCurrentHashAsUInt128() { throw null; } | ||
[System.CLSCompliantAttribute(false)] | ||
public static System.UInt128 HashToUInt128(System.ReadOnlySpan<byte> source, long seed = 0) { throw null; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It would have been better to condition on a compatibility check / version check:
to not lose the API on net7.0 when
$(NetCoreAppCurrent)
becomes net8.0. This just started failing in the PR that upgrades to net8.0: https://github.com/dotnet/runtime/pull/78354/checks?check_run_id=9846188314.I will change this in our PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks