Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update arm32 test queues for msquic #76267

Merged
merged 10 commits into from
Oct 3, 2022
Merged

update arm32 test queues for msquic #76267

merged 10 commits into from
Oct 3, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Sep 27, 2022

No description provided.

@wfurt wfurt added arch-arm32 os-linux Linux OS (any supported distro) test-enhancement Improvements of test source code labels Sep 27, 2022
@wfurt wfurt self-assigned this Sep 27, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: wfurt
Assignees: wfurt
Labels:

arch-arm32, area-Infrastructure-libraries, os-linux, test-enhancement

Milestone: -

@wfurt wfurt marked this pull request as ready for review September 28, 2022 00:50
@wfurt wfurt closed this Sep 28, 2022
@wfurt wfurt reopened this Sep 28, 2022
@wfurt
Copy link
Member Author

wfurt commented Sep 28, 2022

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Sep 28, 2022

/azp run extra-platforms

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@wfurt
Copy link
Member Author

wfurt commented Sep 28, 2022

/azp run extra-platforms

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@wfurt
Copy link
Member Author

wfurt commented Sep 29, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Sep 30, 2022

I still see lot of Http and Quic failures.
Can you please take a look @rzikm? It is hard to guess if the machine is just slow, or it is environmental problem or if there is still something wrong with MsQuic.

rzikm
rzikm previously approved these changes Sep 30, 2022
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm rzikm dismissed their stale review September 30, 2022 08:05

Test failures

@rzikm
Copy link
Member

rzikm commented Sep 30, 2022

I still see lot of Http and Quic failures. Can you please take a look @rzikm? It is hard to guess if the machine is just slow, or it is environmental problem or if there is still something wrong with MsQuic.

This looks very suspicious, what version of MsQuic do the images have?

@rzikm
Copy link
Member

rzikm commented Sep 30, 2022

I see, the images use published 2.1.1, which does not have microsoft/msquic@51cd036. We either need MsQuic to release 2.1.2 or build from main (which would be a bit problematic on arm32 since some necessary tools are arm64 only)

@wfurt
Copy link
Member Author

wfurt commented Oct 2, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@wfurt
Copy link
Member Author

wfurt commented Oct 3, 2022

arm test seems to finish successfully
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76267-merge-e2b3fb48f5094d65bc/System.Net.Quic.Functional.Tests/1/console.1b5d7ac4.log?helixlogtype=result

Console log: 'System.Net.Quic.Functional.Tests' from job e2b3fb48-f509-4d65-bc8a-550d7d6845f2 (ubuntu.1804.armarch.open) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-arm32v7-20221001191150-66a2140 on ddvsotx2l200

===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 106 of 112 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 4)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 326, Errors: 0, Failed: 0, Skipped: 1, Time: 149.877s


@wfurt wfurt merged commit 4334863 into dotnet:main Oct 3, 2022
@wfurt wfurt deleted the arm32update branch October 3, 2022 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 area-Infrastructure-libraries os-linux Linux OS (any supported distro) test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants