JIT: Expand delegate calls in morph #75841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand delegate calls in morph to allow CSE'ing and hoisting of delegate targets/instances. Fix dotnet#75832 Close dotnet#75255
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Looks like we may need to do something about #75751 before this to avoid regressions, I'm seeing many diffs like the following, where we now clobber an argument register containing a local we need: G_M13290_IG02: ; gcrefRegs=00000002 {rcx}, byrefRegs=00000000 {}, byref
; gcrRegs +[rcx]
- movzx rdx, byte ptr [rcx+10H]
+ mov gword ptr [rsp+08H], rcx
+ ; GC ptr vars +{V00}
mov rax, gword ptr [rcx+08H]
; gcrRegs +[rax]
mov rcx, gword ptr [rax+08H]
- ;; size=12 bbWeight=1 PerfScore 6.00
+ mov rdx, gword ptr [rsp+08H]
+ ; gcrRegs +[rdx]
+ movzx rdx, byte ptr [rdx+10H]
+ ; gcrRegs -[rdx]
+ ;; size=22 bbWeight=1 PerfScore 8.00
G_M13290_IG03: ; , epilog, nogc, extend
- tail.jmp [rax+18H]hackishMethodName
+ tail.jmp [rax+18H] |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand delegate calls in morph to allow CSE'ing and hoisting of delegate targets/instances.
Fix #75832
Close #75255
Also fix printing of GT_CALL nodes. Late args were not being printed in correct evaluation order.