[release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test #74181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #74112 to release/7.0-rc1 /cc @dakersnar @sakno Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Asking a last minute clarifying question to the PR author, then I will approve this. |
carlossanlop
requested review from
tannergooding,
dakersnar and
danmoseley
and removed request for
danmoseley,
tannergooding and
dakersnar
carlossanlop
added
the
NO-MERGE
dakersnar
removed
the
NO-MERGE
dakersnar
approved these changes
Aug 19, 2022
|
Approved for RC1 as it's a basic numeric correctness issue and a regression. |
|
Approved and signed off. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74112 to release/7.0-rc1
/cc @dakersnar @sakno
Customer Impact
The correctness of BigInteger's
ModPowhas regressed since .NET 6 for some edge cases.Testing
A unit test has been added that is now passing thanks to the fix.
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.