Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Use buffer.Length as the source of truth for ReadDirectoryChanges' nBufferLength #74023

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #73970 to release/7.0-rc1

/cc @jozkee

Customer Impact

Testing

Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 16, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #73970 to release/7.0-rc1

/cc @jozkee

Customer Impact

Testing

Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.IO

Milestone: -

@danmoseley
Copy link
Member

Approved offline.

@jozkee jozkee added this to the 7.0.0 milestone Aug 16, 2022
@jozkee jozkee self-assigned this Aug 16, 2022
@danmoseley
Copy link
Member

Opened #74034 for the cert test failure.

@carlossanlop
Copy link
Member

Approved by Dan.
Signed off by me.
CI failures are unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 12d9354 into release/7.0-rc1 Aug 17, 2022
@carlossanlop carlossanlop deleted the backport/pr-73970-to-release/7.0-rc1 branch August 17, 2022 01:22
@carlossanlop carlossanlop restored the backport/pr-73970-to-release/7.0-rc1 branch August 17, 2022 01:22
@carlossanlop carlossanlop deleted the backport/pr-73970-to-release/7.0-rc1 branch August 17, 2022 01:23
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants