fix credential caching on macOS #73577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThe behavior was not predictable and depends on order of tests (and parallelism) The credential cache is based on specific leaf certificate and not entire chain. So when using same certificate with different chain we may get unexpected results. Minimal fix for this is to copy certificates (and other info) from SslAuthenticationOptions that is specific to particular SslStream instead of contributes to #73295
|
rzikm
approved these changes
Aug 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior was not predictable and depends on order of tests (and parallelism) The credential cache is based on specific leaf certificate and not entire chain. So when using same certificate with different chain we may get unexpected results.
Minimal fix for this is to copy certificates (and other info) from SslAuthenticationOptions that is specific to particular SslStream instead of
credentialthat can be shared among many sessions. Unlike Windows, the credentials are somewhat useless anyway and cost of setting up the chain is identical.contributes to #73295